If file has no preprocessor symbols, only format it once #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shocklateboy92
approved these changes
Jan 21, 2022
| @@ -38,7 +38,7 @@ public async Task Should_Format_Basic_File(string lineEnding) | |||
| var formattedContent = "public class ClassName { }" + lineEnding; | |||
| var unformattedContent = $"public class ClassName {{{lineEnding}{lineEnding}}}"; | |||
|
|
|||
| await WriteFileAsync("BasicFile.cs", unformattedContent); | |||
| await this.WriteFileAsync("BasicFile.cs", unformattedContent); | |||
There was a problem hiding this comment.
If you want to always prepend this., that's fine, but could you change all of them in a single PR?
Littering the changes all over the place makes it hard to review.
There was a problem hiding this comment.
Yeah sorry, I went ahead and merged it - #562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #555