order modifiers #744
order modifiers #744
Conversation
|
The other part of this is figuring out how to get |
|
Is this forgotten? I just ran into this issue, and would love to see it implemented. |
|
|
||
| public int Compare(string? x, string? y) | ||
| { | ||
| int GetIndex(string? value) |
There was a problem hiding this comment.
why is this a nested method?
I feel like it could be a private static method in that class.
| { | ||
| int GetIndex(string? value) | ||
| { | ||
| var result = Array.IndexOf(DefaultOrdered, value); |
There was a problem hiding this comment.
So, this gets called for every comparison of every declaration in the source code, right?
It might be worth optimizing to be constant time access by say, initializing a static dictionary of string to index.
| #if !SILVERLIGHT | ||
| unsafe | ||
| #endif | ||
| static String Method() { } |
There was a problem hiding this comment.
Damn, how did you even come up with this case 😲
an attempt to fix #725
I believe now comes the "opinionated" part, I could implement this order default value (which I found after this quick implementation):
public, private, protected, internal, file, static, extern, new, virtual, abstract, sealed, override, readonly, unsafe, required, volatile, asyncfrom:
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0036