Fix captcha checking and discriminate empty search result or zero citing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry I haven't responded earlier! Is this PR still relevant? Does it need any updates? |
|
Yes, it is still working properly. |
|
Any chance of merging this pull request? I also have zero citation count problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Scholar page has been updated that there is no 'RecaptchaOptions' in the page when Google is checking if you are a robot. Besides, the default order of open an URL in order to disable the robot checking would open system browser firstly, which would not resolve the robot checking. Instead, using zotero internal browser is helpful, so I prioritized the internal browser.
For discriminating situations when there is no search result or the result has no citing number like in #26 , I make the extra field 'No Citation Data' when the search result is empty by counting result div elements with class 'gs_r gs_or gs_scl'.