Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

diff #14

wants to merge 1 commit into from

Conversation

belovdv
Copy link
Owner

@belovdv belovdv commented Mar 28, 2023

No description provided.

petrochenkov
petrochenkov reviewed Mar 28, 2023
View reviewed changes
tests/run-make/jobserver-error/test.rs Outdated
let fd = not_jobserver.as_raw_fd();
unsafe {
cmd.pre_exec(move || {
libc::fcntl(fd, libc::F_SETFD, 0);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing FD_CLOEXEC, right?
It needs an explaining comment.

@belovdv belovdv force-pushed the fix-panic-jobserver-token branch 2 times, most recently from 6a4c830 to e1fdb21 Compare March 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belovdv @petrochenkov