Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg configuration files #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hallfox
Copy link

@hallfox hallfox commented May 3, 2024

This should be the minimal set of files to support a vcpkg-backed toolchain. Further instructions on how one can add more dependencies for to be fetched by vcpkg can be found at the getting started page on vcpkg's docs.

@JeffGarland
Copy link

@bretbrownjr this seems to be languishing -- can you have a look?

@wusatosi wusatosi mentioned this pull request Oct 4, 2024
@wusatosi
Copy link
Member

This conflicts with #44, I can look into this after #44 is merged.

@wusatosi
Copy link
Member

@hallfox would you mind rebasing this pr to adopt the CMakePresets.json from #44?

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JeffGarland JeffGarland self-requested a review October 22, 2024 15:13
Copy link

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified to review this, but I'm approving so we can move forward.

@wusatosi
Copy link
Member

Anyway we can test this?

@hallfox
Copy link
Author

hallfox commented Oct 22, 2024

Best way would be to add a vcpkg based toolchain to the CI matrix.

@wusatosi
Copy link
Member

wusatosi commented Oct 22, 2024

I cannot verify this, the added file doesn't seem to effect vcpkg toolchain at all.

This is what I've attempted:

  1. installed the vcpkg environment as suggested on the referenced setup instruction
  2. Passed -DCMAKE_TOOLCHAIN_FILE=$VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake to cmake configure on a ubuntu 20.04 based codespace environment
  3. Project builds correctly.
  4. Removes the build directory
  5. Corrupts the files in this pr
  6. Configures with the same tool chain
  7. Project still builds successfully

Again I am not familiar with this tool chain, I am just confused on what these two files adds....

@camio
Copy link
Contributor

camio commented Oct 30, 2024

Best way [to test] would be to add a vcpkg based toolchain to the CI matrix.

@hallfox, do you intend to add something like this as part of this PR? If not, is there a series of commands we can run manually to verify that this works as expected.

@wusatosi

This comment was marked as resolved.

Copy link
Member

@wusatosi wusatosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened a pr for the CI side of vcpkg configuration, see #68 . It is still a work in process.
Should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants