-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vcpkg configuration files #7
base: main
Are you sure you want to change the base?
Conversation
@bretbrownjr this seems to be languishing -- can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really qualified to review this, but I'm approving so we can move forward.
Anyway we can test this? |
Best way would be to add a vcpkg based toolchain to the CI matrix. |
I cannot verify this, the added file doesn't seem to effect vcpkg toolchain at all. This is what I've attempted:
Again I am not familiar with this tool chain, I am just confused on what these two files adds.... |
@hallfox, do you intend to add something like this as part of this PR? If not, is there a series of commands we can run manually to verify that this works as expected. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened a pr for the CI side of vcpkg configuration, see #68 . It is still a work in process.
Should be ready to merge.
This should be the minimal set of files to support a vcpkg-backed toolchain. Further instructions on how one can add more dependencies for to be fetched by vcpkg can be found at the getting started page on vcpkg's docs.