Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'as' prop to types #846

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Jan 12, 2024

Add missing type for prop as.

This removes the need for the workaround proposed here:

Also, it works better because the as prop is only available for styled components.

@ben-rogerson
Copy link
Owner

Thanks heaps for adding this PR - i'll include it within the next update.

@klzns
Copy link
Contributor Author

klzns commented Jan 17, 2024

@ben-rogerson not rushing or anything, but when do you plan to do the next update?

Thanks for your work! I'm a huge fan!

@ben-rogerson ben-rogerson merged commit b29327e into ben-rogerson:master Jan 19, 2024
1 check passed
@ben-rogerson
Copy link
Owner

ben-rogerson commented Jan 19, 2024

Next version is now published - thanks again for adding the missing type.
And great to hear you're enjoying twin 🎉

@klzns klzns deleted the fix-as-type branch January 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants