Bump actions/dependency-review-action from 3.1.0 to 3.1.5 #116
dependabot[bot]dependency-review.yml
on: pull_request
dependency-review
10s
Annotations
11 warnings
|
unnecessary use of `.write(true)` because there is `.append(true)`:
src/main.rs#L353
warning: unnecessary use of `.write(true)` because there is `.append(true)`
--> src/main.rs:353:13
|
353 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
|
|
unnecessary use of `.write(true)` because there is `.append(true)`:
src/main.rs#L111
warning: unnecessary use of `.write(true)` because there is `.append(true)`
--> src/main.rs:111:17
|
111 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
= note: `#[warn(clippy::ineffective_open_options)]` on by default
|
|
you seem to use `.enumerate()` and immediately discard the index:
src/problem/p0912_sort_an_array.rs#L64
warning: you seem to use `.enumerate()` and immediately discard the index
--> src/problem/p0912_sort_an_array.rs:64:27
|
64 | for (_i, item) in nums.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
help: remove the `.enumerate()` call
|
64 | for item in nums.iter() {
| ~~~~ ~~~~~~~~~~~
|
|
you seem to use `.enumerate()` and immediately discard the index:
src/problem/p0912_sort_an_array.rs#L55
warning: you seem to use `.enumerate()` and immediately discard the index
--> src/problem/p0912_sort_an_array.rs:55:27
|
55 | for (_i, item) in nums.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
55 | for item in nums.iter() {
| ~~~~ ~~~~~~~~~~~
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/problem/p0912_sort_an_array.rs#L53
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/problem/p0912_sort_an_array.rs:53:19
|
53 | fn sort(nums: &Vec<i32>, k: u32) -> Vec<i32> {
| ^^^^^^^^^ help: change this to: `&[i32]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/problem/p0043_multiply_strings.rs#L60
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/problem/p0043_multiply_strings.rs:60:28
|
60 | fn add(a: &Vec<u8>, b: &Vec<u8>) -> Vec<u8> {
| ^^^^^^^^ help: change this to: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/problem/p0043_multiply_strings.rs#L60
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/problem/p0043_multiply_strings.rs:60:15
|
60 | fn add(a: &Vec<u8>, b: &Vec<u8>) -> Vec<u8> {
| ^^^^^^^^ help: change this to: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
src/problem/p0027_remove_element.rs#L76
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> src/problem/p0027_remove_element.rs:76:34
|
76 | pub fn remove_element1(nums: &mut Vec<i32>, val: i32) -> i32 {
| ^^^^^^^^^^^^^ help: change this to: `&mut [i32]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
src/problem/p0027_remove_element.rs#L58
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> src/problem/p0027_remove_element.rs:58:33
|
58 | pub fn remove_element(nums: &mut Vec<i32>, val: i32) -> i32 {
| ^^^^^^^^^^^^^ help: change this to: `&mut [i32]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
you seem to use `.enumerate()` and immediately discard the index:
src/problem/p0912_sort_an_array.rs#L64
warning: you seem to use `.enumerate()` and immediately discard the index
--> src/problem/p0912_sort_an_array.rs:64:27
|
64 | for (_i, item) in nums.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
help: remove the `.enumerate()` call
|
64 | for item in nums.iter() {
| ~~~~ ~~~~~~~~~~~
|
|
you seem to use `.enumerate()` and immediately discard the index:
src/problem/p0912_sort_an_array.rs#L55
warning: you seem to use `.enumerate()` and immediately discard the index
--> src/problem/p0912_sort_an_array.rs:55:27
|
55 | for (_i, item) in nums.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
55 | for item in nums.iter() {
| ~~~~ ~~~~~~~~~~~
|