https and popup fix

ben1one · Dec 13, 2022 · c4ffdf8 · c4ffdf8
1 parent 643bd15
commit c4ffdf8
Show file tree

Hide file tree

Showing 3 changed files with 79 additions and 69 deletions.
diff --git a/background_with_deps.js b/background_with_deps.js
@@ -439,8 +439,18 @@ googleShareButton.onProviderShared = function(providerId, title, sharedUrl) {
           var providerUrl = getPopulatedUrl_(provider.url, title, shortUrl);
           newWindow.location.replace(providerUrl)
         })
-      }else {
-        window.open(getPopulatedUrl_(provider.url, title, sharedUrl), "", "menubar=1,resizable=1,width=800,height=570")
+      } else {
+        chrome.windows.create({
+          url: getPopulatedUrl_(provider.url, title, sharedUrl),
+          width: 800,
+          height: 650,
+          top: 200,
+          left: 200,
+          type: "popup",
+        }, function (win) {
+          chrome.windows.update(win.id, { focused: false });
+        });
+        // window.open(getPopulatedUrl_(provider.url, title, sharedUrl), "", "menubar=1,resizable=1,width=800,height=570")
       }
     }
   }else {

diff --git a/manifest.json b/manifest.json
@@ -8,7 +8,7 @@
 		"default_popup": "popup.html"
 	},
 	"name": "__MSG_sharebutton_extension_name__",
-	"version": "1.1.0.14",
+	"version": "1.1.0.15",
 	"manifest_version": 2,
 	"default_locale": "en",
 	"description": "Use the Share extension to share webpages via your social networks, email and blogs.",