Rework source sets to have rich hierarchy #130
Conversation
|
@benasher44 with these changes, I can successfully publish both (playground and pgf) projects. It was just a matter of taking the emulated locations and mapping them into a hierarchy |
|
thanks for doing this! |
| val jsMain by getting { dependsOn(nonJvmMain) } | ||
| val jsTest by getting { dependsOn(nonJvmTest) } |
There was a problem hiding this comment.
looks like jsMain doesn't exist. guessing it's named differently between the IR and non-IR JS variants
There was a problem hiding this comment.
i would comment this out, list the tasks, see what the names are like, and update based on that
There was a problem hiding this comment.
weird, I'm not really sure how it was compiling previously, because js and jvm targets were only declared if the host was a Mac machine. I added a bunch of HostManager checks and it looks like it is building successfully now
|
Nope! I'll merge 'er in |
|
oh nvm, I can't |
| @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/), and this | |||
| project adheres to [Semantic Versioning](https://semver.org/). | |||
|
|
|||
| ## [0.6.0] - 2022-11-07 | |||
There was a problem hiding this comment.
will try to release today, but no promises!
There was a problem hiding this comment.
what about the date? looks correct
There was a problem hiding this comment.
Oh it looks fine. It's just optimistic
There was a problem hiding this comment.
Oh, heh. Not a rush at all!
I thought I messed up the month/day order, but you've been using a sane system since the beginning :)
Fixes or Changes Proposed
According to https://youtrack.jetbrains.com/issue/KT-54512 ticket, this repo only had a
commonMainsource set, while other source sets were emulated by customizing source set locations. This PR reworks source sets so that they form a parent-child hierarchy, which addresses #129.PR Checklist