Add kotlin-js-store to source control #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I generally agree with the sentiment, but the build is failing. Can you take a look? |
|
I just pushed the updated yarn.lock file. I think what happened is that I commited a stale version from Kotlin 1.9 (and main was still 1.8 at the time). And now that #140 is merged, it's going to change again. I need to go in a bit but I'll rebase later today, see how it goes. |
martinbonnin
force-pushed
the
add-kotlin-js-store
branch
from
29bf40b
to
d19a415
Compare
|
Alright, I had time to the the rebase 😄 . Now I really need to go, will check back in a few to see if it passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kotlin-js-store should be committed for build reproduceability