Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hash bug + prevent useless RegEx call #3

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

SlIdE42
Copy link
Contributor

@SlIdE42 SlIdE42 commented Dec 20, 2021

No description provided.

@lobre
Copy link

lobre commented Dec 21, 2021

I am playing with this package and I saw that no assets were cached, probably because of this "missing hash bug". Or otherwise, if it is intended behavior, I just don’t understand the code :-)

Thanks for having submitted the PR @SlIdE42. Looking forward to have this fixed!

@SlIdE42
Copy link
Contributor Author

SlIdE42 commented Dec 21, 2021

I am playing with this package and I saw that no assets were cached, probably because of this "missing hash bug". Or otherwise, if it is intended behavior, I just don’t understand the code :-)

Thanks for having submitted the PR @SlIdE42. Looking forward to have this fixed!

This is the offending line of code (partly my fault):
https://github.com/benbjohnson/hashfs/blob/main/hashfs.go#L51

@lobre
Copy link

lobre commented Dec 21, 2021

This is the offending line of code (partly my fault):

Glad that this is a bug because I scratched my head 30 minutes on that open function yesterday saying to myself that I missed something ^^.

@benbjohnson benbjohnson merged commit 04f3b63 into benbjohnson:main Dec 21, 2021
@benbjohnson
Copy link
Owner

Thanks, @SlIdE42. Released as https://github.com/benbjohnson/hashfs/releases/tag/v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants