Add support for %k, %l, %u, %W, missing test for %e and extra test for %Z #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm depending on a few more strftime-format string specifiers -
%k
,%l
are hours without leading zero,%u
is day of week with sunday=7 and%W
is the week number, this PR introduces them.Technically, they're not strictly compatible because that would require a leading space for
%k
&%l
but it's the closest we can get without a full rewrite.Also, the entries for
z
&Z
were out order alphabetically.This also adds a missing test for
%e
, an additional date - needed for the leading-zero/nothing difference, and a test that tests that%Z
is still passed to moment - according to moment#162, it should keep working whenmoment-timezone
is also used.