Make Cache instance/class user-configurable via options.cache
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
phryneas
commented
Nov 16, 2023
Answering "why not both?" to this discussion: benjamn#615 (comment)
benjamn
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
I've published these changes as [email protected] for you to test @phryneas, but I have one question I want to clear with you (below) before we publish 0.18.0.
benjamn
approved these changes
Nov 28, 2023
benjamn
changed the title
Cache class used configurableCache instance/class user-configurable
benjamn
changed the title
Cache instance/class user-configurableCache instance/class user-configurable via options.cache
phryneas
commented
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the promised PR :)