Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Mexican female names, male names and last names #848

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

itaquito
Copy link
Contributor

Hey!

I added some Mexican names and last names as #710 asked. The source I used is the INEGI, which is the organization of demographic data of Mexico.

Hope it helps! Thanks.

@benkeen
Copy link
Owner

benkeen commented Oct 26, 2023

Great stuff, thanks @itaquito! One question: I see for a lot of the first names, there are 2 names like Maria Jose or Evelyn Guadalupe. Would the second be considered a middle name or part of the first name? The reason I ask is that the Names field has a bunch of placeholders like MaleName and FemaleName so I wanted to confirm that it would be appropriate for both names to appear if the user entered one of those placeholders.

@itaquito
Copy link
Contributor Author

That's a really interesting question. Technically, it's considered as a middle name, however, you can also consider it as a whole first name since we only use certain combinations of first names and middle names.

For instance, it's common for a female name to use Maria and a male name to use José as the first name and then another name as the middle name. Other combinations that may be generated randomly like Valentina Regina are not really a common thing.

I think it's appropriate for both names to appear as just one name. However, I do understand that it may be unexpected to users that the placeholders MaleName and FemaleName generate two words. Tell me what you decide! If you want, I can edit the list and just leave the one-word names.

@benkeen
Copy link
Owner

benkeen commented Oct 26, 2023

Yeah, interesting one! I think it should probably be considered correct though. Let's add it in as-is and see if anyone complains about it. Thanks again! I'll release a new version this weekend to include your change. :)

@benkeen benkeen merged commit fd53850 into benkeen:master Oct 26, 2023
@benkeen benkeen added this to the 4.1.6 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants