Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
benoit-pierre committed Jun 15, 2017
1 parent eba6ed4 commit 9f81546
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 13 deletions.
2 changes: 1 addition & 1 deletion setuptools/dist.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def parse_config_files(self, filenames=None):
and loads configuration.
"""
_Distribution.parse_config_files(self, filenames=filenames)
Distribution_parse_config_files.parse_config_files(self, filenames=filenames)

parse_configuration(self, self.command_options)
if getattr(self, 'python_requires', None):
Expand Down
22 changes: 11 additions & 11 deletions setuptools/py36compat.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import io
import sys
from distutils.errors import DistutilsOptionError
from distutils.util import strtobool
from distutils.debug import DEBUG
from setuptools.extern import six


class Distribution_parse_config_files:
Expand All @@ -13,10 +15,10 @@ class Distribution_parse_config_files:
as implemented in distutils.
"""
def parse_config_files(self, filenames=None):
from configparser import ConfigParser
from setuptools.extern.six.moves.configparser import ConfigParser

# Ignore install directory options if we have a venv
if sys.prefix != sys.base_prefix:
if six.PY3 and sys.prefix != sys.base_prefix:
ignore_options = [
'install-base', 'install-platbase', 'install-lib',
'install-platlib', 'install-purelib', 'install-headers',
Expand All @@ -33,18 +35,22 @@ def parse_config_files(self, filenames=None):
if DEBUG:
self.announce("Distribution.parse_config_files():")

parser = ConfigParser(interpolation=None)
parser = ConfigParser()
for filename in filenames:
if DEBUG:
self.announce(" reading %s" % filename)
parser.read(filename)
with io.open(filename, encoding='utf-8') as fp:
if six.PY3:
parser.read_file(fp)
else:
parser.readfp(fp)
for section in parser.sections():
options = parser.options(section)
opt_dict = self.get_option_dict(section)

for opt in options:
if opt != '__name__' and opt not in ignore_options:
val = parser.get(section,opt)
val = parser.get(section,opt,raw=True)
opt = opt.replace('-', '_')
opt_dict[opt] = (filename, val)

Expand All @@ -69,12 +75,6 @@ def parse_config_files(self, filenames=None):
raise DistutilsOptionError(msg)


if sys.version_info < (3,):
# Python 2 behavior is sufficient
class Distribution_parse_config_files:
pass


if False:
# When updated behavior is available upstream,
# disable override here.
Expand Down
27 changes: 26 additions & 1 deletion setuptools/tests/test_config.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# -*- coding: UTF-8 -*-
from __future__ import unicode_literals

import contextlib
import pytest
from distutils.errors import DistutilsOptionError, DistutilsFileError
from setuptools.dist import Distribution
from setuptools.config import ConfigHandler, read_configuration
from setuptools.tests import is_ascii


class ErrConfigHandler(ConfigHandler):
Expand All @@ -26,7 +30,7 @@ def fake_env(tmpdir, setup_cfg, setup_py=None):

tmpdir.join('setup.py').write(setup_py)
config = tmpdir.join('setup.cfg')
config.write(setup_cfg)
config.write(setup_cfg.encode('utf-8'), mode='wb')

package_dir, init_file = make_package_dir('fake_package', tmpdir)

Expand Down Expand Up @@ -288,6 +292,27 @@ def test_classifiers(self, tmpdir):
with get_dist(tmpdir) as dist:
assert set(dist.metadata.classifiers) == expected

def test_no_interpolation(self, tmpdir):
fake_env(
tmpdir,
'[metadata]\n'
'description = %(message)s\n'
)
with get_dist(tmpdir) as dist:
assert dist.metadata.description == '%(message)s'

skip_if_not_ascii = pytest.mark.skipif(not is_ascii, reason='Test not supported with this locale')

@skip_if_not_ascii
def test_non_ascii(self, tmpdir):
fake_env(
tmpdir,
'[metadata]\n'
'description = éàïôñ\n'
)
with get_dist(tmpdir) as dist:
assert dist.metadata.description == 'éàïôñ'


class TestOptions:

Expand Down

0 comments on commit 9f81546

Please sign in to comment.