Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: revert macos-14 runners, migrate to tox v4-exclusive settings, add Python 3.13 #3211

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

pajod
Copy link
Contributor

@pajod pajod commented May 12, 2024

  1. A few other PRs have degraded CI results because Github does not provide Python 3.7 on the default macos-latest runners.

    • Suggestion: just drop back to macos-13, an try the macos-latest image just for a single known-good version.
    • Considered alternative: keep defaults and special case the other way around: not great while the macos-14 images also have unrelated issues.
  2. The tox.ini contained supersedes settings and a reference to unpleasant behaviour in a scenario we may entirely avoid by using the package / no_package flags instead of skipsdist and usedevelop.

    • Suggestion: Just assert we are using tox v4 and let tox prepare something more like what we actually need for each tests
  3. The upcoming Python 3.13 version comes with some interesting changes (see Check that threads works well with Gunicorn and Python 3.13 (I think that It doesn't) #3205) which warrant some expansion in the area of automatic tests

@benoitc benoitc merged commit 405c3ca into benoitc:master Jul 4, 2024
23 checks passed
pajod pushed a commit to pajod/gunicorn that referenced this pull request Jul 31, 2024
CI: revert macos-14 runners, migrate to tox v4-exclusive settings, add Python 3.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants