-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host header invalid for http+unix://
url values
#382
Comments
PR to fix this coming later today. |
fp
pushed a commit
to fp/hackney
that referenced
this issue
Jan 28, 2017
When sending the `host` header for a request to a unix domain socket the value must be url encoded, since most such values have invalid slash characters. (fixes benoitc#382)
fp
pushed a commit
to fp/hackney
that referenced
this issue
Jan 28, 2017
When sending the `host` header for a request to a unix domain socket the value must be url encoded, since most such values have invalid slash characters. (fixes benoitc#382)
This fixed makes the hackney side of things correct, and also requires a corresponding changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TLDR; when sending a
http+unix://
request, thehost:
header should be url encoded.Assuming a request like the following is made is made to a unix domain socket:
This results in a
400
response from cowboy (correctly) because the host header is sent as the unix domain socket file name, but not url encoded. The full trace:The text was updated successfully, but these errors were encountered: