Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new url format for unix socket #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

benoitc
Copy link
Owner

@benoitc benoitc commented Aug 21, 2020

Current way to pass the socket requires the user to url encode the path.
For example /var/run/mysocketshould be encoded as
%2Fvar%2Frun%2Fmyscoket which is not really convenient.

Changes:

We introduce thiss tuple as a ne format {<<"unix:/var/run/mysock'>>,<<"http://path/to/resource"> }

This allows the user to pass a path withut encoding it while supporting
extensions in the future.

note: for now only http is suppored.

Current way to pass the socket requires the user to url encode the path.
For example "/var/run/mysocket' should be encoded as
"%2Fvar%2Frun%2Fmyscoket" which is not really convenient.

Changes:

We introduce thiss tuple as a ne format {<<"unix:/var/run/mysock'>>,
<<"http://path/to/resource"> }

This allows the user to pass a path withut encoding it while supporting
extensions in the future.

note: for now only http is suppored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant