Internationalize/I18n the Dashboard Engine

@bensheldon, I had a little bit of progress, so I would like to share it with you
bensheldon · Jan 26, 2022 · fbe0144 · fbe0144
1 parent 6f0a3fa
commit fbe0144
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 2 deletions.
diff --git a/engine/app/controllers/good_job/base_controller.rb b/engine/app/controllers/good_job/base_controller.rb
@@ -27,7 +27,8 @@ class BaseController < ActionController::Base # rubocop:disable Rails/Applicatio
     private
 
     def switch_locale(&action)
-      I18n.with_locale(:en, &action)
+      locale = params[:locale] || I18n.default_locale
+      I18n.with_locale(locale, &action)
     end
   end
 end
diff --git a/engine/app/views/layouts/good_job/base.html.erb b/engine/app/views/layouts/good_job/base.html.erb
@@ -20,7 +20,7 @@
 <body>
   <nav class="navbar navbar-expand-lg navbar-light bg-light">
     <div class="container-fluid">
-      <%= link_to "GoodJob 👍", root_path, class: 'navbar-brand mb-0 h1' %>
+      <%= link_to t("app_name"), root_path, class: 'navbar-brand mb-0 h1' %>
       <button class="navbar-toggler" type="button" data-toggle="collapse" data-bs-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">
         <span class="navbar-toggler-icon"></span>
       </button>

diff --git a/engine/config/locales/en.yml b/engine/config/locales/en.yml
@@ -0,0 +1,2 @@
+en:
+  app_name: "GoodJob 👍"
diff --git a/engine/config/locales/es.yml b/engine/config/locales/es.yml
@@ -0,0 +1,2 @@
+es:
+  app_name: "BuenTrabajo 👍"
diff --git a/spec/system/dashboard_spec.rb b/spec/system/dashboard_spec.rb
@@ -96,4 +96,12 @@
       end.to change { unfinished_job.head_execution(reload: true).finished_at }.to within(1.second).of(Time.current)
     end
   end
+
+  describe "I18n" do
+    it "renders good_job in Spanish", js: true do
+      I18n.default_locale = :es
+      visit "/good_job"
+      expect(page).to have_content "BuenTrabajo 👍"
+    end
+  end
 end