-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard/engine – i18n: Wrong translation scope #605
Comments
Jay-Schneider
added a commit
to Jay-Schneider/good_job
that referenced
this issue
May 23, 2022
@Jay-Schneider thanks for reporting this! You're correct, the scope should be |
Jay-Schneider
added a commit
to Jay-Schneider/good_job
that referenced
this issue
May 23, 2022
Merged
@Jay-Schneider This has been released in v2.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
I encountered a problem when updating good_job from
2.14.2
to2.15.0
regarding the hereby introduced internationalization.The application I am running is configured to raise an exception instead of falling back to display the key in question.
When I visit the dashboard I receive a
I18n::MissingTranslationData in GoodJob::Jobs#index
statingtranslation missing: en.status.scheduled
.I figured out that this is actually a problem in the gem, where the view refers to
scope: '.status'
while the locale file actually has the translations nested undergood_job.status
(which might be the better choice here imho).good_job/engine/app/views/good_job/shared/_filter.erb
Lines 10 to 13 in 265f5bf
good_job/engine/config/locales/en.yml
Lines 48 to 65 in 265f5bf
So maybe the fix just constists of adjusting to scope to
.goodjob.status
?Additionally one might consider configuring i18n to raise during tests so that such mistakes are not concealed.
Best regards 👋
The text was updated successfully, but these errors were encountered: