Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not Critical] Too much space (One) in db/migrate/XXXXXX_create_index_good_jobs_jobs_on_priority_created_at_when_unfinished.rb #851

Closed
julienanne opened this issue Feb 17, 2023 · 3 comments · Fixed by #852

Comments

@julienanne
Copy link
Contributor

Hi,

Very not critical issue.
When I generate update migration, with rails generate good_job:update the file linked after was generated with 3 spaces instead of two on the line 5.
https://github.com/bensheldon/good_job/blob/main/lib/generators/good_job/templates/update/migrations/03_create_index_good_jobs_jobs_on_priority_created_at_when_unfinished.rb.erb#L5

Have a nice day
Julien

@bensheldon
Copy link
Owner

@julienanne thank you for reporting this! Would you be able to make a PR to fix it?

@julienanne
Copy link
Contributor Author

I don't promise but I will try ;)

julienanne added a commit to julienanne/good_job that referenced this issue Feb 17, 2023
Three spaces instead of two generate a rubocop issue
@julienanne
Copy link
Contributor Author

#852 There was no spec on this part but all other spec are green on my local installation.

Hope it's help.

Have a nice day.
Julien

bensheldon pushed a commit that referenced this issue Feb 17, 2023
Three spaces instead of two generate a rubocop issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants