We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
Very not critical issue. When I generate update migration, with rails generate good_job:update the file linked after was generated with 3 spaces instead of two on the line 5. https://github.com/bensheldon/good_job/blob/main/lib/generators/good_job/templates/update/migrations/03_create_index_good_jobs_jobs_on_priority_created_at_when_unfinished.rb.erb#L5
rails generate good_job:update
Have a nice day Julien
The text was updated successfully, but these errors were encountered:
@julienanne thank you for reporting this! Would you be able to make a PR to fix it?
Sorry, something went wrong.
I don't promise but I will try ;)
Fix template for the update migrations 03 index (bensheldon#851)
e18b96a
Three spaces instead of two generate a rubocop issue
#852 There was no spec on this part but all other spec are green on my local installation.
Hope it's help.
Have a nice day. Julien
Fix template for the update migrations 03 index (#851) (#852)
5093a59
Successfully merging a pull request may close this issue.
Hi,
Very not critical issue.
When I generate update migration, with
rails generate good_job:update
the file linked after was generated with 3 spaces instead of two on the line 5.https://github.com/bensheldon/good_job/blob/main/lib/generators/good_job/templates/update/migrations/03_create_index_good_jobs_jobs_on_priority_created_at_when_unfinished.rb.erb#L5
Have a nice day
Julien
The text was updated successfully, but these errors were encountered: