Replace Webrick with custom simple http server #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixpac
force-pushed
the
dix/implement_custom_http_server
branch
from
c9833e7
to
227b6f8
Compare
dixpac
commented
Aug 5, 2023
| @@ -46,6 +46,9 @@ Layout/ParameterAlignment: | |||
| Lint/AmbiguousBlockAssociation: | |||
| Enabled: false | |||
|
|
|||
| Lint/IncompatibleIoSelectWithFiberScheduler: | |||
There was a problem hiding this comment.
Fiber-aware scheduling, instead of ths
ready_sockets, = IO.select([@server])
this:
@server.wait_readable
But afaik Ruby 2.x.x, doesn't have fiber-aware scheduling or wait_readable, so I've disabled this linter.
dixpac
force-pushed
the
dix/implement_custom_http_server
branch
5 times, most recently
from
215f502
to
24d8341
Compare
This commit removes Webrick and replaces it with a (simple) custom HttpServer. This is a single-process/singe-thread server that behaves simmilary to webrick.
dixpac
force-pushed
the
dix/implement_custom_http_server
branch
from
24d8341
to
20fcda2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes Webrick and replaces it with a (simple) custom HttpServer.
This is a single-process/singe-thread server that behaves similarly to webrick.
Initially I've build this implementation to comfort to
Rack::Handlerinterface, but looks like rack team is removingRack::Handlerfrom the rack gem into separate gem and I'm not sure about the future ofRack::Handler, so i reverted to this implementation.Resolves #1017