Respect the configured execution mode, even within the CLI #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
force-pushed
the
cli_execution_mode
branch
from
0f480b2
to
541c3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1052.
"Execution Mode" is a bit overly broad because it defines both what the Adapter should do with the job after it is enqueued, as well as what background work should be activated (e.g. cron, job scheduler, etc.)
In this case, I think it makes sense that when executing jobs within the CLI that setting execution mode should still configure what the Active Job Adapter does with jobs that enqueued during the performance of other jobs. In this case:
:externaljobs are enqueued and executed anywhere:inlinejobs are enqueued and executed inline:async_alljobs are enqueued and are attempted to be executed within the same process, and if that's not possible, then treated like:externaljobs:asyncwhich is intended to only configure behavior on webservers. If a CLI is configured in:asyncmode, the execution mode treated as:external