Add JRuby 9.4 to testing matrix; nerf ActiveJob::TestQueueAdapter overrides #1067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am experiencing problems with JRuby 9.4.3.0 and the usage of
prepend
and callingdescendants
(which is called byActiveJob::TestHelper
, with exceptions that look like: jruby/jruby#6896It is a little strange though because it could be a combination of
stub_constant
and doing weird things with ActiveSupport::Concern like:good_job/lib/good_job/active_job_extensions/concurrency.rb
Lines 23 to 24 in d1cde17
Unfortunately, I wasn't able to isolate it down, but my working theory is that something like this should be problematic (though maybe it is specifically
stub_const
):