-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make health probe server more general purpose #1079
Merged
bensheldon
merged 30 commits into
bensheldon:main
from
jklina:make-web-server-general-purpose
Jan 23, 2024
Merged
Make health probe server more general purpose #1079
bensheldon
merged 30 commits into
bensheldon:main
from
jklina:make-web-server-general-purpose
Jan 23, 2024
Commits on Sep 17, 2023
-
Make health probe server more general purpose
This removes the health check logic from the ProbeServer and renames the ProbeServer to UtilityServer that accepts any Rack based app. The health check and catchall logic are moved into simple Rack middleware that can be composed by users however they like and be used to preserve existing health check behavior while transitioning to a more general purpose utility server. All and all this pattern will allow users to add whatever functionality they like to GoodJob's web server by composing Rack apps and using GoodJob's configuration to pass in users' Rack apps. IE: ``` config.good_job.middleware = Rack::Builder.app do use GoodJob::Middleware::MyCustomMiddleware use GoodJob::Middleware::PrometheusExporter use GoodJob::Middleware::Healthcheck run GoodJob::Middleware::CatchAll end config.good_job.middleware_port = 7001 ``` This could help resolve: * bensheldon#750 * bensheldon#532
Configuration menu - View commit details
-
Copy full SHA for 51aaf5e - Browse repository at this point
Copy the full SHA 51aaf5eView commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff1c8ad - Browse repository at this point
Copy the full SHA ff1c8adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a2ee38 - Browse repository at this point
Copy the full SHA 7a2ee38View commit details -
We decided to leave the original ProbeServer name better sets expectations. See: bensheldon#1079 (review) This also splits out middleware testing into separate specs.
Configuration menu - View commit details
-
Copy full SHA for eb63619 - Browse repository at this point
Copy the full SHA eb63619View commit details
Commits on Dec 12, 2023
-
This also helps ensure that the existing behavior and API remain intact.
Configuration menu - View commit details
-
Copy full SHA for ea9a964 - Browse repository at this point
Copy the full SHA ea9a964View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6535288 - Browse repository at this point
Copy the full SHA 6535288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff54d7 - Browse repository at this point
Copy the full SHA 8ff54d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6ee6db - Browse repository at this point
Copy the full SHA a6ee6dbView commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d5520aa - Browse repository at this point
Copy the full SHA d5520aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac2885c - Browse repository at this point
Copy the full SHA ac2885cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f92de5b - Browse repository at this point
Copy the full SHA f92de5bView commit details
Commits on Jan 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 911798d - Browse repository at this point
Copy the full SHA 911798dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed08af0 - Browse repository at this point
Copy the full SHA ed08af0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd59f43 - Browse repository at this point
Copy the full SHA cd59f43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54955d1 - Browse repository at this point
Copy the full SHA 54955d1View commit details
Commits on Jan 4, 2024
-
Warn and fallback when WEBrick isn't loadable
Since the probe server has the option to use WEBrick as a server handler, but this library doesn't have WEBrick as a dependency, we want to throw a warning when WEBrick is configured, but not in the load path. This will also gracefully fallback to the built in HTTP server.
Configuration menu - View commit details
-
Copy full SHA for 59486a1 - Browse repository at this point
Copy the full SHA 59486a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59efbe9 - Browse repository at this point
Copy the full SHA 59efbe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0239a9b - Browse repository at this point
Copy the full SHA 0239a9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d66ce - Browse repository at this point
Copy the full SHA c0d66ceView commit details -
For error on require to initiate test
As opposed to manipulating the load path.
Configuration menu - View commit details
-
Copy full SHA for 4226b27 - Browse repository at this point
Copy the full SHA 4226b27View commit details
Commits on Jan 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b8375f - Browse repository at this point
Copy the full SHA 0b8375fView commit details -
Configuration menu - View commit details
-
Copy full SHA for be6bb19 - Browse repository at this point
Copy the full SHA be6bb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0615186 - Browse repository at this point
Copy the full SHA 0615186View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3359a1d - Browse repository at this point
Copy the full SHA 3359a1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ecca37 - Browse repository at this point
Copy the full SHA 7ecca37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a1fdcd - Browse repository at this point
Copy the full SHA 5a1fdcdView commit details
Commits on Jan 6, 2024
-
Rename
probe_server_app
toprobe_app
; make handler name a symbol;…… rename Rack middleware/app for clarity
Configuration menu - View commit details
-
Copy full SHA for 5429fd7 - Browse repository at this point
Copy the full SHA 5429fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c67ba6 - Browse repository at this point
Copy the full SHA 1c67ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 206660a - Browse repository at this point
Copy the full SHA 206660aView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2d9a4d2 - Browse repository at this point
Copy the full SHA 2d9a4d2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.