-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address rails 7.1 deprecation when using ActiveJobExtensions::Concurrency
#1097
Conversation
45b02f3
to
8a5304c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just came here to create a PR, this is how I would have solved it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 same here as @mhenrixon. Thanks @Earlopain
thank you! |
Just a note, rc (and probably beta) versions don't match like this. The deprecation warning will stop triggering once a non-preview version of rails is released. |
@Earlopain oh, we should fix that. There's a version matcher that will include RC versions, I just need to find/remember what it is. |
My bad, I wasn't aware about that functionality. As per the docs appending |
Thanks! I'll make that change on |
Hey @bensheldon I see you’ve released 3.19.4 but the latest version released on rubygems.org is 3.19.3. Could you push 3.19.4 to rubygems.org? |
Oops! Sorry about that! I just pushed the gem. |
Closes #1096, it's a simple fix so why not do it myself.
There are still a few references to exponentially_longer in the readme but it didn't seem wise to change those while it's not actually usable. I did change one instance in the readme where it explains what it does, since it's not actually exponetially longer but if you think that's just going to cause confusion I'll just drop that.