Allow env variable config for cleanups #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
approved these changes
Aug 31, 2020
lib/good_job/configuration.rb
Outdated
| @@ -51,5 +51,13 @@ def poll_interval | |||
| 1 | |||
| ).to_i | |||
| end | |||
|
|
|||
| def before_seconds_ago | |||
There was a problem hiding this comment.
I think this method should be named "cleanup_preserved_jobs_before_seconds_ago". It's a little unsymmetrical because the command line option isn't the whole phrase, but the longer phrase seems like the appropriate message to ask of the configuration object.
There was a problem hiding this comment.
Yes, that came to my mind at first, but decided not to do as I wasn't going to change the public configuration option GoodJob asks from user.
Changed now
gadimbaylisahil
deleted the
feature/enable-env-variable-for-good-job-clean-jobs-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #110
I was thinking to add tests to CLI specs as well but think configuration is sufficient.