Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1152

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Update README.md #1152

merged 2 commits into from
Nov 21, 2023

Conversation

LucasKendi
Copy link
Contributor

Fix Batch code snipet.

This PR fixes the code snipet for batches creation. The add method was being used on a GoodJob::Batches class instead of it's instance

  • Running GoodJob::Batch.add raises a undefined method 'add' for GoodJob::Batch:Class (NoMethodError).

@LucasKendi
Update README.md
6d31787 
Fix Batch description. `add` is not a GoodJob::Batch class method
@bensheldon
Copy link
Owner

Thank you!

@LucasKendi
Update README.md
085d968 
Remove trailing white space
@bensheldon bensheldon merged commit 7534b70 into bensheldon:main Nov 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcovecchio Marcovecchio Marcovecchio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasKendi @bensheldon @Marcovecchio