-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate cron indexes to be conditional #1163
Merged
bensheldon
merged 3 commits into
bensheldon:main
from
defkode:1161_partial_indices_for_cron_key
Dec 1, 2023
Merged
Recreate cron indexes to be conditional #1163
bensheldon
merged 3 commits into
bensheldon:main
from
defkode:1161_partial_indices_for_cron_key
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@defkode sorry, I realized I have so much experience doing this :D
...so ultimately this should be updates to 4 files:
|
defkode
force-pushed
the
1161_partial_indices_for_cron_key
branch
from
November 28, 2023 07:59
d23ff87
to
baec364
Compare
defkode
changed the title
recreate_index_good_jobs_on_cron_key
Recreate good_jobs cron indexes
Nov 28, 2023
@bensheldon Thanks for hints. PR is updated. |
bensheldon
changed the title
Recreate good_jobs cron indexes
Recreate cron indexes to be conditional
Dec 1, 2023
…ve concurrent from initial install migration
@defkode thank you! I just made a few tweaks. I'm going to let CI run through 💚 and then it should be done ⭐ |
I'm pretty certain this is failing because of a change introduced today on Rails main: rails/rails#50205 (comment) |
@bensheldon Thanks! |
bensheldon
added
enhancement
New feature or request
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Dec 1, 2023
bensheldon
added a commit
that referenced
this pull request
Dec 2, 2023
…exes Fixes issue introduced in #1163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1161