Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese locale #1226

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Brazilian Portuguese locale #1226

merged 4 commits into from
Jan 31, 2024

Conversation

hss-mateus
Copy link
Contributor

A little addition of a pt-BR locale file into the collection.

Thanks for regularly maintaining and improving this gem!

Copy link

@jmonteiro jmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native Brazilian Portuguese speaker I reviewed those translations, and they look good :-)

@@ -0,0 +1,243 @@
---
pt_br:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a small note, some apps might use pt-BR instead of pt_BR. Not sure if or how this can be handled though.

Suggested change
pt_br:
pt-br:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this! From a code search, it looks like it may not be strictly necessary: https://github.com/search?type=code&q=path%3Aconfig%2Flocales%2F*.yml+%2F%5Ept%5B_-%5Dbr%2F

And seems like both RubyGems.org and Mastodon use pt-BR so I'll go with that. I'll make that change.

@bensheldon bensheldon merged commit 9dc526a into bensheldon:main Jan 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants