Tweak docs for new concurrency default #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1145. When I initially wrote this I expected all arguments to be part of the concurrency key by default. Now that that isn't the case anymore it doesn't really make sense to use transient arguments as an example since that is something the user has thought about already when setting a custom key.
I've instead chosen the (probably) common case of
def perform(my_model)and added a note about what you need to do to make that work. model.to_s is something like#<MyModel:0x00007f3f634a7320>which won't work. On it's own this argument isn't allowed but when used in interpolation it will just be cast to a string so I added a note about that as well.