Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default engine cron value #1258

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix default engine cron value #1258

merged 4 commits into from
Feb 22, 2024

Conversation

hss-mateus
Copy link
Contributor

The engine sets an default value for the cron configuration, causing it to ignore the ENV value, if it exists (source).

This PR just removes the default value and adds some test cases to ensure the ENV value is considered.

bensheldon
bensheldon approved these changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

(btw, the CI failure is unrelated; I'm fixing that right now and then will accept this)

@bensheldon bensheldon changed the title Remove default engine cron value Fix default engine cron value Feb 21, 2024
@bensheldon bensheldon added the bug Something isn't working label Feb 21, 2024
@bensheldon bensheldon merged commit f125052 into bensheldon:main Feb 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensheldon bensheldon bensheldon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hss-mateus @bensheldon