Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require_relative and do not modify $LOAD_PATH in gemspec #1283

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Use require_relative and do not modify $LOAD_PATH in gemspec #1283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions good_job.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
# frozen_string_literal: true

require_paths = ["lib"]
require_paths.each do |require_path|
$LOAD_PATH.push File.expand_path(require_path, __dir__)
end

# Maintain your gem's version:
require "good_job/version"
require_relative "lib/good_job/version"

# Describe your gem and declare its dependencies:
Gem::Specification.new do |spec|
spec.name = "good_job"
spec.version = GoodJob::VERSION
Expand Down Expand Up @@ -36,7 +29,7 @@ Gem::Specification.new do |spec|
"CHANGELOG.md",
"LICENSE.txt",
]
spec.require_paths = require_paths
spec.require_paths = ["lib"]
spec.bindir = "exe"
spec.executables = %w[good_job]

Expand All @@ -51,12 +44,12 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = ">= 2.6.0"

spec.add_dependency "activejob", ">= 6.0.0"
spec.add_dependency "activerecord", ">= 6.0.0"
spec.add_dependency "concurrent-ruby", ">= 1.0.2"
spec.add_dependency "fugit", ">= 1.1"
spec.add_dependency "railties", ">= 6.0.0"
spec.add_dependency "thor", ">= 0.14.1"
spec.add_runtime_dependency "activejob", ">= 6.0.0"
spec.add_runtime_dependency "activerecord", ">= 6.0.0"
spec.add_runtime_dependency "concurrent-ruby", ">= 1.0.2"
spec.add_runtime_dependency "fugit", ">= 1.1"
spec.add_runtime_dependency "railties", ">= 6.0.0"
spec.add_runtime_dependency "thor", ">= 0.14.1"

spec.add_development_dependency "benchmark-ips"
spec.add_development_dependency "capybara"
Expand Down
76 changes: 38 additions & 38 deletions lib/good_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,44 +3,44 @@
require "active_job"
require "active_job/queue_adapters"

require "good_job/version"
require "good_job/engine"

require "good_job/adapter"
require "active_job/queue_adapters/good_job_adapter"
require "good_job/active_job_extensions/batches"
require "good_job/active_job_extensions/concurrency"
require "good_job/interrupt_error"
require "good_job/active_job_extensions/interrupt_errors"
require "good_job/active_job_extensions/labels"
require "good_job/active_job_extensions/notify_options"

require "good_job/overridable_connection"
require "good_job/bulk"
require "good_job/callable"
require "good_job/capsule"
require "good_job/cleanup_tracker"
require "good_job/cli"
require "good_job/configuration"
require "good_job/cron_manager"
require "good_job/current_thread"
require "good_job/daemon"
require "good_job/dependencies"
require "good_job/job_performer"
require "good_job/job_performer/metrics"
require "good_job/log_subscriber"
require "good_job/multi_scheduler"
require "good_job/notifier"
require "good_job/poller"
require "good_job/probe_server"
require "good_job/probe_server/healthcheck_middleware"
require "good_job/probe_server/not_found_app"
require "good_job/probe_server/simple_handler"
require "good_job/probe_server/webrick_handler"
require "good_job/scheduler"
require "good_job/shared_executor"
require "good_job/systemd_service"
require "good_job/thread_status"
require_relative "good_job/version"
require_relative "good_job/engine"

require_relative "good_job/adapter"
require_relative "active_job/queue_adapters/good_job_adapter"
require_relative "good_job/active_job_extensions/batches"
require_relative "good_job/active_job_extensions/concurrency"
require_relative "good_job/interrupt_error"
require_relative "good_job/active_job_extensions/interrupt_errors"
require_relative "good_job/active_job_extensions/labels"
require_relative "good_job/active_job_extensions/notify_options"

require_relative "good_job/overridable_connection"
require_relative "good_job/bulk"
require_relative "good_job/callable"
require_relative "good_job/capsule"
require_relative "good_job/cleanup_tracker"
require_relative "good_job/cli"
require_relative "good_job/configuration"
require_relative "good_job/cron_manager"
require_relative "good_job/current_thread"
require_relative "good_job/daemon"
require_relative "good_job/dependencies"
require_relative "good_job/job_performer"
require_relative "good_job/job_performer/metrics"
require_relative "good_job/log_subscriber"
require_relative "good_job/multi_scheduler"
require_relative "good_job/notifier"
require_relative "good_job/poller"
require_relative "good_job/probe_server"
require_relative "good_job/probe_server/healthcheck_middleware"
require_relative "good_job/probe_server/not_found_app"
require_relative "good_job/probe_server/simple_handler"
require_relative "good_job/probe_server/webrick_handler"
require_relative "good_job/scheduler"
require_relative "good_job/shared_executor"
require_relative "good_job/systemd_service"
require_relative "good_job/thread_status"

# GoodJob is a multithreaded, Postgres-based, ActiveJob backend for Ruby on Rails.
#
Expand Down