Set an implicit order on models #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we use uuids as primary keys the order of objects can be unexpected without an explicit sort order. By setting the `implicit_order_column` to `created_at` we get back the expected behaviour of sequential primary keys. https://api.rubyonrails.org/classes/ActiveRecord/ModelSchema.html#method-c-implicit_order_column
mec
force-pushed
the
add-implicit-sort-order-to-models
branch
from
eb7a8eb
to
501da1c
Compare
bensheldon
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we use uuids as primary keys the order of objects can be unexpected
without an explicit sort order.
By setting the
implicit_order_columntocreated_atwe get back theexpected behaviour of sequential primary keys.
https://api.rubyonrails.org/classes/ActiveRecord/ModelSchema.html#method-c-implicit_order_column
This work resolves #1242