Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require rack/handler for rack >= 3.1.x #1383

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

shouichi
Copy link
Contributor

From rack >= 3.1.x, Rack::Handler is not auto-loaded anymore. Though we should migrate to Rackup::Handler, we can't in the short term. This is because of the support of rails <= 7.0 that doesn't depend on rackup.

From rack >= 3.1.x, `Rack::Handler` is not auto-loaded anymore. Though
we should migrate to `Rackup::Handler`, we can't in the short term. This
is because of the support of rails <= 7.0 that doesn't depend on rackup.
@Earlopain
Copy link
Collaborator

@bensheldon
Copy link
Owner

bensheldon commented Jun 24, 2024

@shouichi @Earlopain Thank you both! I updated it based on the Rails PR, which I think will produce the Rack deprecation warning too during the fallback.

I'm reluctant to add rackup to the gemspec because I don't consider the healtcheck "core" functionality, so at a certain point we'll likely need to catch the loaderror and gracefully handle it with a message like "You'll need to add rackup to your gemfile."

Also, while trying to get Sorbet definition in place, I learned that the rackup 1.0 release is busted: rack/rackup#13 (comment)

@bensheldon bensheldon added the bug Something isn't working label Jun 24, 2024
@bensheldon bensheldon merged commit 301907b into bensheldon:main Jun 24, 2024
15 of 21 checks passed
@bensheldon
Copy link
Owner

@shouichi shouichi deleted the workaround-for-rack-3.1.x branch June 25, 2024 02:39
@shouichi
Copy link
Contributor Author

@Earlopain Thank you for the feedback!

@bensheldon Thank you for the quick release! I confirmed the release works as intended in rails 7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants