Configure GoodJob via Rails.application.config
instead of recommending GoodJob::Adapter.new
#199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a moderately significant change in recommended configuration.
The problem is that calling
GoodJob::Adapter.new
withinconfig/application.rb
orconfig/environments/*.rb
causes the Adapter to be instantiated too early in the Rails initialization process.This addresses #195, #89.
This also contains changes to
GoodJob::Performer
, making it less generic and renaming it toGoodJob::JobPerformer
. The intent is to to clearly delay references to GoodJob::Job. This is necessary because there is a circular dependency in Rails 6.1 when ActiveJob initializes GoodJob, which references ActiveRecord, which tries to initialize ActiveJob (for the destroy associations async feature).