Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of Rails queue adapter with :good_job #28

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Jul 13, 2020

Closes #5

@bensheldon bensheldon merged commit 75e1728 into main Jul 13, 2020
@bensheldon bensheldon deleted the rails_adapter_symbol branch July 13, 2020 19:15
@aried3r
Copy link
Contributor

aried3r commented Aug 11, 2021

Hey! We're looking into different ActiveJob backends right now. I was wondering, is this something that could go upstream into Rails itself with the others?

https://github.com/rails/rails/tree/main/activejob/lib/active_job/queue_adapters

@reczy
Copy link
Contributor

reczy commented Aug 11, 2021

@aried3r - Unfortunately not possible at this time.

https://api.rubyonrails.org/files/activejob/README_md.html

Supported queuing systems
Active Job has built-in adapters for multiple queuing backends (Sidekiq, Resque, Delayed Job and others). To get an up-to-date list of the adapters see the API Documentation for ActiveJob::QueueAdapters.

Please note: We are not accepting pull requests for new adapters. We encourage library authors to provide an ActiveJob adapter as part of their gem, or as a stand-alone gem. For discussion about this see the following PRs: 23311, 21406, and #32285.

@aried3r
Copy link
Contributor

aried3r commented Aug 11, 2021

Oh, I wasn't aware. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow config.active_job.queue_adapter = :good_job to work
3 participants