Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Test Matrix with latest JRuby 9.3.0.0 #387

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Update GH Test Matrix with latest JRuby 9.3.0.0 #387

merged 3 commits into from
Sep 25, 2021

Conversation

tedt10e
Copy link
Contributor

@tedt10e tedt10e commented Sep 25, 2021

No description provided.

@tedt10e
Copy link
Contributor Author

tedt10e commented Sep 25, 2021

Hi Ben,

Shall we also keep the latest version of JRuby 9.2? (9.2.19.0)

@bensheldon
Copy link
Owner

@tedhexaflow Good question, my understanding of JRuby has changed. Now that I understand JRuby a little better, I think we should track 9.2.latest and 9.3.latest.

For MRI Ruby, my policy is to keep the 2.6.latest, 2.7.latest, 3.0.latest.

My mistake earlier was that I believed that there were functional differences between 9.2.13.0 and 9.2.16.0. But now I see that the entire JRuby 9.2 series was intended to be equivalent to MRI 2.5, and the JRuby 9.3 series is intended to be compatible with MRI 2.6.

@tedt10e
Copy link
Contributor Author

tedt10e commented Sep 25, 2021

Alrighty!
I'll remove 9.2.13.0 and keep the latest version of 9.2 and 9.3.
For MRI Ruby, we can use 2.6, 2.7 in the matrix, and it will use the latest version.
But I'm not sure we can do the same for JRuby. Let me have a look.

@tedt10e
Copy link
Contributor Author

tedt10e commented Sep 25, 2021

Hi @bensheldon
Cool. It worked.
You can merge the PR 😀
Thanks 🙏

@bensheldon bensheldon merged commit 7b6fe60 into bensheldon:main Sep 25, 2021
@bensheldon
Copy link
Owner

Thank you! 🙌

@bensheldon bensheldon added the dependencies Pull requests that update a dependency file label Sep 25, 2021
@tedt10e tedt10e deleted the gh-test-matrix-jruby-9.3.0.0 branch September 25, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants