Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Readme's "Optimize queues, threads, processes" section #405

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

Hugo-Hache
Copy link
Contributor

Closes #132.

  • Introduce multiple pools and multiple processes paragraphs with an explanation of this particular strategy benefit
  • Clarify the pool configuration syntax in queues configuration
  • Clarify that max-threads is per pool, not global
  • Format examples with linebreaks
  • Separate combined process over a single type example

@Hugo-Hache
Copy link
Contributor Author

👋 @bensheldon, I discovered GoodJob a few days ago, and while integrating it in my project, I jumped on the hacktoberfest occasion to learn more about the library. I settled on this documentation issue as others were a bit steep for me.

I'm no expert of concurrency, so please let me know if any of my additions is incorrect.

Copy link
Owner

@bensheldon bensheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Hugo-Hache Thank you for tackling this! These changes look great and are really valuable. Thank you!

@bensheldon bensheldon merged commit 1a7e4e9 into bensheldon:main Oct 5, 2021
@bensheldon
Copy link
Owner

Connects to #393.

@bensheldon bensheldon added the hacktoberfest Issues that are good for Hacktoberfest participants label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues that are good for Hacktoberfest participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Readme's "Optimize queues, threads, processes" section
2 participants