Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Cron dashboard screen; add jobs drill-drown and enqueue-now action #436

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

bensheldon
Copy link
Owner

Connects to #392.

  • Creates more space by putting job properties within a collapsible element.
  • Moves ActiveJobJob class out of the engine and into lib

Screen Shot 2021-10-27 at 8 35 53 AM

Screen Shot 2021-10-27 at 8 36 00 AM

@bensheldon bensheldon temporarily deployed to goodjob-cron-entries-dr-1xjnji October 27, 2021 15:38 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-cron-entries-dr-1xjnji October 27, 2021 16:08 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-cron-entries-dr-1xjnji October 27, 2021 20:26 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-cron-entries-dr-1xjnji October 27, 2021 20:40 Inactive
@bensheldon
Copy link
Owner Author

@ssendev would you mind giving me some feedback on this Dashboard improvement for Cron?

https://goodjob-cron-entries-dr-1xjnji.herokuapp.com/good_job/cron_entries

@reczy
Copy link
Contributor

reczy commented Oct 27, 2021

wow, the dashboard is really coming along nicely!

@bensheldon - thoughts on a confirm popup before executing actions (particularly discard job?). I realize it's annoying if you're trying to act on many rows but I personally think the potential safety net there outweighs the inconvenience.

@bensheldon
Copy link
Owner Author

@reczy great suggestion! Yes, these should have confirm dialogs.

I should package up UJS as one of the assets. It makes life so much easier (and gives some niceties like disable, and some SJR desires I have for improving charts and auto-refreshing data)

…w action

- Creates more space by putting job properties within a collapsible element.
- Moves `ActiveJobJob` class out of the engine and into `lib`
@bensheldon bensheldon temporarily deployed to goodjob-cron-entries-dr-1xjnji October 28, 2021 23:55 Inactive
@ssendev
Copy link

ssendev commented Oct 29, 2021

Oh, jeah this looks nice. Thanks for the quick implementation and i guess the project in general. One might say you did a good job ;-)

@bensheldon bensheldon merged commit a0da08a into main Oct 29, 2021
@bensheldon bensheldon deleted the cron-entries-drilldown branch October 29, 2021 15:05
@bensheldon bensheldon added the enhancement New feature or request label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants