Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GoodJob global configuration accessors to also be set via Rails config hash #460

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Nov 27, 2021

Deprecates all GoodJob configuration accessors, in favor of Rails configuration hash.

I was originally planning to deprecate them now, but I plan with GoodJob 3.0 to change them as a result of #412 so I'll deprecate most of them (with the exception of logger and on_thread_error) when I do that.

Connects to #380.

@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 27, 2021 16:45 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 27, 2021 23:32 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 28, 2021 00:17 Inactive
@bensheldon bensheldon changed the title Deprecate global configuration setters from GoodJob class Allow GoodJob global configuration accessors to also be set via Rails config hash Nov 28, 2021
lib/good_job/railtie.rb Outdated Show resolved Hide resolved
@bensheldon bensheldon marked this pull request as ready for review November 28, 2021 00:34
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 28, 2021 21:02 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 28, 2021 21:44 Inactive
@bensheldon bensheldon added the enhancement New feature or request label Nov 28, 2021
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 29, 2021 15:33 Inactive
@bensheldon bensheldon temporarily deployed to goodjob-global-configur-fkggzw November 29, 2021 15:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant