Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, preserve job records and automatically them clean up #545

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

bensheldon
Copy link
Owner

@bensheldon bensheldon commented Mar 25, 2022

Connects to #507.

Automatically enables #465

@bensheldon bensheldon temporarily deployed to goodjob-preserve-and-cl-38u1su March 25, 2022 16:56 Inactive
@bensheldon bensheldon added enhancement New feature or request v3.0 labels Mar 30, 2022
@bensheldon bensheldon mentioned this pull request Apr 5, 2022
5 tasks
@fameoflight
Copy link

It make sense to include a default job that clean up old job, then people can put them in cron schedule as needed.

For this purpose it might make sense to generate models also for GoodJobs at the very least

@bensheldon
Copy link
Owner Author

@fameoflight when GoodJob 3.0 is released, GoodJob will do the cleaning up of jobs automatically on its own.

@bensheldon bensheldon marked this pull request as ready for review June 26, 2022 02:30
@bensheldon bensheldon merged commit 7e2a1d4 into main Jun 26, 2022
@bensheldon bensheldon deleted the preserve_and_cleanup branch June 26, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3.0
Projects
Development

Successfully merging this pull request may close these issues.

2 participants