Allow concurrency limits to be configured dynamically with lambda/proc #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
changed the title
|
@bensheldon Thanks for solving that issue. Sorry about that. I'm having some problems setting up the local environment, hence running the test suite. Xcode and rbtrace aren't playing together nicely. Which OS are you using? |
|
@baka-san I'm using MacOS 12.5. I should clean up the Gemfile's development section because rbtrace isn't necessary, only nice to have for debugging deadlocks. |
|
@baka-san I just removed some unnecessary dev dependencies. Let me know if that fixes things for you. This PR looks good right now so I'll merge it when CI passes 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set dynamic concurrency limits (i.e.
total_limit,enqueue_limit, andperform_limit) via a proc similar to how a key can be set via a proc. Discussed in issue #684.