Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SemanticLogger logging with improve stdout logic and tagged logs #715

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

bensheldon
Copy link
Owner

Closes #667.

  • Semantic logger overrides ActiveSupport::Logger.logger_outputs_to? to always return true
  • Being extra defensive with the tagged logging construction; at expense of performance (but probably fine).

@bensheldon bensheldon temporarily deployed to goodjob-semantic-logger-4kvgdq September 26, 2022 20:30 Inactive
@bensheldon bensheldon added the bug Something isn't working label Sep 26, 2022
@bensheldon bensheldon merged commit 991a2d0 into main Sep 26, 2022
@bensheldon bensheldon deleted the semantic_logger branch September 26, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Unable to Replace GoodJob's Logger
1 participant