Dashboard's tables update #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ajmal this is great! You have definitely surpassed my skills with flexbox 🙇🏻 It looks like the badges stopped being aligned to the end of the row. Do you think you can fix that?
|
|
@bensheldon sure, I fixed these tables Jobs Jobs/:id/Executions Batches Thank you |
|
@Ajmal thank you! I really appreciate it. I'd love to know if you have any other ideas/improvements for the Dashboard or anything else about GoodJob. This is excellent. |
|
@bensheldon sure, I have not use GoodJob in production environment yet. I will give feedback for Dashboard after I migrate from DJ to GoodJob. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for #829 feedback