Add execution_result to event payload for perform_job.good_job #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable listeners to log different things depending on the result of execution
segiddins
added a commit
to rubygems/rubygems.org
that referenced
this pull request
Mar 13, 2023
segiddins
added a commit
to rubygems/rubygems.org
that referenced
this pull request
Mar 13, 2023
|
Adding to the payload is good, but I'm reluctant to expose the ExecutionResult as part of the public interface. Would it be ok to add the discrete params to the payload instead? |
|
Something like |
bensheldon
reviewed
Mar 13, 2023
app/models/good_job/execution.rb
Outdated
| @@ -345,9 +345,9 @@ def perform | |||
| end | |||
| handled_error ||= current_thread.error_on_retry || current_thread.error_on_discard | |||
|
|
|||
| ExecutionResult.new(value: value, handled_error: handled_error, retried: current_thread.error_on_retry.present?) | |||
| instrument_payload[:execution_result] = ExecutionResult.new(value: value, handled_error: handled_error, retried: current_thread.error_on_retry.present?) | |||
There was a problem hiding this comment.
As part of the public interface, I want to be explicit
Suggested change
| instrument_payload[:execution_result] = ExecutionResult.new(value: value, handled_error: handled_error, retried: current_thread.error_on_retry.present?) | |
| instrument_payload.merge!( | |
| value: value, | |
| handled_error: handled_error, | |
| retried: current_thread.error_on_retry.present? | |
| ) |
segiddins
added a commit
to rubygems/rubygems.org
that referenced
this pull request
Mar 14, 2023
segiddins
added a commit
to rubygems/rubygems.org
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable listeners to log different things depending on the result of execution (in particular, I will use it to log the result as a statsd tag)