Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract more Dashboard strings into localization strings #899

Merged
merged 12 commits into from
Apr 2, 2023
Merged

Extract more Dashboard strings into localization strings #899

merged 12 commits into from
Apr 2, 2023

Conversation

patriciomacadden
Copy link
Contributor

Hi! I've migrated our app that's been running with delayed_job for 7 years to good_job and I immediately fell in love with it. I'm a native spanish speaker so it was nice to see good_job has i18n support (though I would use the english version). I noticed only a bunch of strings were translated so wanted to see if a PR like this one would be helpful.

It's far for complete, but again, wanted to see if a PR like this one would be helpful.

  • most of the UI is translated (there are some hidden strings I'd translate before merging)
  • yaml structure is open for discussion
  • it's got some controller notices translated (the rest will be translated)
  • I haven't translated other locales, but can give it a go with the help of our friend google translate

I might be forgetting something, so if you come up with something let me know.

Cheers!

PS: Here are some screenshots with the before and after:

image
image

@bensheldon
Copy link
Owner

❤️ This is fantastic ✨

My approach with I18n is trying to balance it as something that I think communicates care, and also unfortunately trails adding new features. So I really appreciate you helping close the gap.

I can use i18n-tasks to pull down translations from Google Translate in an automated way. Don't sweat that (lints will fail until I do).

Could you take a look at the RSpec test failures?

@patriciomacadden
Copy link
Contributor Author

Absolutely! I honestly haven't run those yet. Now that I know this is worth continuing I'll finish all the translations (controllers, hidden strings in views, etc) and will take care of the tests. Just gimme a couple of days!

Cheers!

@patriciomacadden
Copy link
Contributor Author

hey there!

Finished all view translations and looked at the tests. Ended up running i18n-tasks add-missing as otherwise there's one test that would fail. Can revert those files if needed.

Cheers!

@bensheldon bensheldon changed the title improve translations [WIP] Extract more Dashboard strings into localization strings Apr 2, 2023
@bensheldon
Copy link
Owner

Something isn't right with GH Actions; they appear to be running against the wrong commit. Locally, this looks fantastic to me 👍🏻

@bensheldon bensheldon merged commit 6318e14 into bensheldon:main Apr 2, 2023
@bensheldon bensheldon added the enhancement New feature or request label Apr 2, 2023
@patriciomacadden
Copy link
Contributor Author

Awesome, thanks for merging! Let me know if there's something to fix re i18n. Happy to help!

bensheldon added a commit that referenced this pull request Apr 11, 2023
@dependabot @eric-christian
@bensheldon @ain2108 @patriciomacadden @ckdake
Bump erb_lint from 0.3.1 to 0.4.0 (#906)
3794dbf 
* Bump rails from 7.0.4.2 to 7.0.4.3 (#904)

Bumps [rails](https://github.com/rails/rails) from 7.0.4.2 to 7.0.4.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.4.2...v7.0.4.3)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump selenium-webdriver from 4.8.1 to 4.8.6 (#905)

Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.8.1 to 4.8.6.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/commits)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump benchmark-ips from 2.11.0 to 2.12.0 (#907)

Bumps [benchmark-ips](https://github.com/evanphx/benchmark-ips) from 2.11.0 to 2.12.0.
- [Release notes](https://github.com/evanphx/benchmark-ips/releases)
- [Changelog](https://github.com/evanphx/benchmark-ips/blob/master/History.md)
- [Commits](evanphx/benchmark-ips@v2.11.0...v2.12.0)

---
updated-dependencies:
- dependency-name: benchmark-ips
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: locales for de (#903)

Co-authored-by: Eric <[email protected]>

* Add translate_hash to handle missing translation keys that return hashes; only show translatable/available locales in dropdown (#891)

* Update README.md (#902)

* Add `translate_hash` to handle missing translation keys that return hashes; only show translatable/available locales in dropdown

---------

Co-authored-by: Anton Nefedenkov <[email protected]>

* Extract more Dashboard strings into localization strings (#899)

* improve translations

* more translations

* fix translation (fixes test)

* added missing i18n strings

* Translate all languages

* Update DE translation

* Fix missing key

* empty commit

* Fix missing UA string

---------

Co-authored-by: Ben Sheldon [he/him] <[email protected]>

* Extract shared methods/scopes into a BaseExecution to share between Execution and Job models; remove deprecated ActiveJobJob model (#894)

* Release good_job v3.15.0

* Switches from Chrome to Chromium to support Apple M1/Arm CPUs (#910)

* Remove mention of `Batch.add` method that doesn't exist

* Fix lint: missing fr and nl translations; readme whitespace (#914)

* Fix missing fr and nl translations

* Fix whitespace in Readme

* Use `GoodJob.capsule` in CLI instead of creating a new Capsule (#916)

* Set `successfully_enqueued?` when using `perform_all_later` (#917)

* In tests, directly use `connection.truncate_tables` instead of  `ActiveRecord::Tasks::DatabaseTasks.truncate_all` (#918)

* Bump erb_lint from 0.3.1 to 0.4.0

Bumps [erb_lint](https://github.com/Shopify/erb-lint) from 0.3.1 to 0.4.0.
- [Release notes](https://github.com/Shopify/erb-lint/releases)
- [Commits](Shopify/erb_lint@v0.3.1...v0.4.0)

---
updated-dependencies:
- dependency-name: erb_lint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: eric-christian <[email protected]>
Co-authored-by: Eric <[email protected]>
Co-authored-by: Ben Sheldon [he/him] <[email protected]>
Co-authored-by: Anton Nefedenkov <[email protected]>
Co-authored-by: Patricio Mac Adden <[email protected]>
Co-authored-by: Chris Kelly <[email protected]>
@francois-ferrandis francois-ferrandis mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patriciomacadden @bensheldon