-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for rails g good_job:install
#94
Conversation
651bb09
to
a7ba001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. I really appreciate this work 🎉
My comments are primarily around naming. This is hard 😄
1f03b50
to
bc9eaae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more thoughts about organizing the ExampleAppHelper
file and making it ✨
a1cf2c3
to
ddf6585
Compare
6be597d
to
61ae356
Compare
61ae356
to
3170875
Compare
Fixes #57
Reference: https://github.com/foundation/foundation-rails/blob/4dfe9b12e8cf3a1aa04b257ff64c782832efc6a0/spec/features/generator_spec.rb