-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support traffic.max_concurrency for api server and runner #3864
Conversation
2c5294b
to
7bd9b78
Compare
Codecov Report
@@ Coverage Diff @@
## main #3864 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 155 155
Lines 12878 12915 +37
=====================================
- Misses 12878 12915 +37
|
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
9562372
to
4dbd53b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test is pretty minuscule, but this is LGTM
Also I suspect the tests might got cancelled because of the timeout. So you might need to increase the default timeout for our github actions. |
Signed-off-by: Frost Ming <[email protected]>
Here we see it will be a breaking change over our configuration. |
Signed-off-by: Frost Ming [email protected]
What does this PR address?
This PR adds support for
traffic
configuration for both API server and runners.The previous
timeout
setting is moved undertraffic
field plus a new configurationmax_concurrency
, which defaults to infinite.Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.