Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting sklearn package for EECS127/227a #1937

Merged
merged 7 commits into from
Nov 2, 2020

Conversation

matteociccozzi
Copy link
Contributor

Adding the requirement for sklearn for EECS127/227a.

@matteociccozzi
Copy link
Contributor Author

From scikit-learn website:

scikit-learn requires:
Python (>= 3.6)
NumPy (>= 1.13.3)
SciPy (>= 0.19.1)
joblib (>= 0.11)
threadpoolctl (>= 2.0.0)

looks like we may need to add:

  • SciPy == 0.19.*
  • joblib == 0.*
  • threadpoolctl == 2.0.*

Let me know if this seems correct and I can add these lines.

@matteociccozzi
Copy link
Contributor Author

@yuvipanda I can't seem to pass the eecs image build, I'm not sure why.

@matteociccozzi
Copy link
Contributor Author

I believe maybe the dependencies need to be updated? jupyterhub/repo2docker#724

Hopefully fixes issues with offlinenotebook
@yuvipanda
Copy link
Contributor

Thanks for catching that, @matteociccozzi! I've upgraded repo2docker, let's see how this goes.

@matteociccozzi
Copy link
Contributor Author

Looks like that worked, thank you!

@yuvipanda yuvipanda merged commit 9782d59 into berkeley-dsep-infra:staging Nov 2, 2020
yuvipanda added a commit that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants